I'm using the default colours for the slices in a pie chart; however, with more than 8 data points, it runs out of colours, issues warning messages to the screen, and renders subsequent slices in black.

The fix: when fetching colours into the palette, take the current data point id and modulo it by the palette size - the colours will thus cycle.

It needs changing in two places, lines 314 and 523. Diff appears below:

< : denotes lines in 2.0.13
> : denotes my version

314c314,315
< $Settings = array("R"=>$Palette[$ID]["R"],"G"=>$Palette[$ID]["G"],"B"=>$Palette[$ID]["B"],"Alpha"=>$Palette[$ID]["Alpha"]);
---
> $colourid = $ID % count($Palette);
> $Settings = array("R"=>$Palette[$colourid]["R"],"G"=>$Palette[$colourid]["G"],"B"=>$Palette[$colourid]["B"],"Alpha"=>$Palette[$colourid]["Alpha"]);
523c524,526
< { $Settings = array("R"=>$Palette[$ID]["R"]+30,"G"=>$Palette[$ID]["G"]+30,"B"=>$Palette[$ID]["B"]+30,"Alpha"=>$Palette[$ID]["Alpha"]); }
---
> {
> $colourid = $ID % count($Palette);
> $Settings = array("R"=>$Palette[$colourid]["R"]+30,"G"=>$Palette[$colourid]["G"]+30,"B"=>$Palette[$colourid]["B"]+30,"Alpha"=>$Palette[$colourid]["Alpha"]); }

Hello,

I've hit this as well (with 9 data points). The error message is:
---
Notice: Undefined offset: 8 in /var/www/george/lib/pChart2.1.0/class/pPie.class.php on line 314
---

The patch above seems to have resolved the issue.


Thanks,

George.

From pChart 1.27 FAQ, but it is still actual:

Q: Series are drawn black?
A: No, this is not a bug! Series are drawn as black because you do not have enough colors in your palette. Remember, basically pChart embed only colors for 8 series. If you have more than 8 series, you'll need to add colors to you palette. The setPalette() is here to help you!

http://pchart.sourceforge.net/documentation.php?topic=faq.sblack

I believe that it would be good to add a test entry that will create random uggly colors ;o)

JD.