View unanswered posts | View active topics It is currently Sat Apr 27, 2024 9:22 pm



Reply to topic  [ 2 posts ] 
two bugs - I fixed it 
Author Message
Regular pChart user
Regular pChart user

Joined: Tue May 10, 2011 6:22 am
Posts: 9
Post two bugs - I fixed it
1)pImage.class.php-----------------------------------------------------------------------
function autoOutput($FileName="output.png")
{
/* php_sapi_name() == "cli" is not work on my server on windows*/
//if (php_sapi_name() == "cli")
if (true)
$this->Render($FileName);
else
{
$this->Stroke();
}
}
2) pData.class.php-----------------------------------------------------------------------
/* Strip VOID values */
function stripVOID($Values)
{
if($Values=="")
{
$Result[] = 0;
return $Result;
}

$Result = "";
foreach($Values as $Key => $Value)
{
if ( $Value != VOID )
{
$Result[] = $Value;
}
}

if($Result == "") $Result[] = 0;
return($Result);
}

if no data - it's work correct!


Thu Sep 01, 2011 10:59 am
Profile
Site Admin
Site Admin
User avatar

Joined: Thu Dec 02, 2010 2:31 pm
Posts: 409
Location: France
Post Re: two bugs - I fixed it
I do not agree with your first fix. Replacing a conditional test by if ( true ) isn't acceptable -or only for you-. From the PHP documentation the php_sapi_name() function exists since PHP 4 so I must understand that its output didn't fit your expectations.

The second issue has been fixed in a more esthetical way in the next 2.1.3 sub version.

Thanks for your feedback.


Thu Sep 01, 2011 12:53 pm
Profile WWW
Display posts from previous:  Sort by  
Reply to topic   [ 2 posts ] 

Who is online

Users browsing this forum: No registered users and 8 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron