pChart 2.x forum
http://wiki.pchart.net/forum/

two bugs - I fixed it
http://wiki.pchart.net/forum/viewtopic.php?f=5&t=2157
Page 1 of 1

Author:  yava [ Thu Sep 01, 2011 10:59 am ]
Post subject:  two bugs - I fixed it

1)pImage.class.php-----------------------------------------------------------------------
function autoOutput($FileName="output.png")
{
/* php_sapi_name() == "cli" is not work on my server on windows*/
//if (php_sapi_name() == "cli")
if (true)
$this->Render($FileName);
else
{
$this->Stroke();
}
}
2) pData.class.php-----------------------------------------------------------------------
/* Strip VOID values */
function stripVOID($Values)
{
if($Values=="")
{
$Result[] = 0;
return $Result;
}

$Result = "";
foreach($Values as $Key => $Value)
{
if ( $Value != VOID )
{
$Result[] = $Value;
}
}

if($Result == "") $Result[] = 0;
return($Result);
}

if no data - it's work correct!

Author:  jean-damien [ Thu Sep 01, 2011 12:53 pm ]
Post subject:  Re: two bugs - I fixed it

I do not agree with your first fix. Replacing a conditional test by if ( true ) isn't acceptable -or only for you-. From the PHP documentation the php_sapi_name() function exists since PHP 4 so I must understand that its output didn't fit your expectations.

The second issue has been fixed in a more esthetical way in the next 2.1.3 sub version.

Thanks for your feedback.

Page 1 of 1 All times are UTC
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
http://www.phpbb.com/