View unanswered posts | View active topics It is currently Sun Apr 28, 2024 11:26 pm



Reply to topic  [ 5 posts ] 
BreakVoid color 
Author Message
pChart user
pChart user

Joined: Thu Jan 13, 2011 1:49 pm
Posts: 4
Post BreakVoid color
I noticed this error in the pDraw.class lines 3031-3033

Code:
   $BreakR      = isset($Format["BreakR"]) ? $Format["BreakR"] : 234;
   $BreakG      = isset($Format["BreakG"]) ? $Format["BreakG"] : 55;
   $BreakB      = isset($Format["BreakB"]) ? $Format["BreakB"] : 26;


For the following code (lines 3049-3052) to work (and use the serie color) they have to be set to NULL if they're not set in $Format:

Code:
   if ( $BreakR == NULL )
      $BreakSettings = array("R"=>$R,"G"=>$G,"B"=>$B,"Alpha"=>$Alpha,"Ticks"=>$VoidTicks,"Weight"=>$Weight);
   else
      $BreakSettings = array("R"=>$BreakR,"G"=>$BreakG,"B"=>$BreakB,"Alpha"=>$Alpha,"Ticks"=>$VoidTicks,"Weight"=>$Weight);


Thu Jan 13, 2011 1:55 pm
Profile
Site Admin
Site Admin
User avatar

Joined: Thu Dec 02, 2010 2:31 pm
Posts: 409
Location: France
Post Re: BreakVoid color
Hi,

This isn't exactly a bug as I wanted that break line was drawned in red by default but you're right, it is more logical to keep the serie color and allow the user to change it with a custom one manually.

I've modified the next sub release accordingly ;o)

Thank you!
JD.


Thu Jan 13, 2011 3:25 pm
Profile WWW
pChart user
pChart user

Joined: Thu Jan 13, 2011 1:49 pm
Posts: 4
Post Re: BreakVoid color
jean-damien wrote:
This isn't exactly a bug as I wanted that break line was drawned in red by default but you're right, it is more logical to keep the serie color and allow the user to change it with a custom one manually.


If the default color is supposed to be red then why have you written the following in the documentation;
Quote:
If you don‘t set a custom color, the serie color will be used.


Thu Jan 13, 2011 3:29 pm
Profile
Site Admin
Site Admin
User avatar

Joined: Thu Dec 02, 2010 2:31 pm
Posts: 409
Location: France
Post Re: BreakVoid color
Hopefully you've noticed it helping to maintain an up to date documentation ;o)


Thu Jan 13, 2011 5:18 pm
Profile WWW
Site Admin
Site Admin
User avatar

Joined: Thu Dec 02, 2010 2:31 pm
Posts: 409
Location: France
Post Re: BreakVoid color
This has been fixed in the 2.1.0 that you can get from here : download.

Kind regards,
JD.


Wed Jan 26, 2011 3:01 pm
Profile WWW
Display posts from previous:  Sort by  
Reply to topic   [ 5 posts ] 

Who is online

Users browsing this forum: No registered users and 19 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron