pChart 2.x forum
http://wiki.pchart.net/forum/

BreakVoid color
http://wiki.pchart.net/forum/viewtopic.php?f=5&t=69		 Page 1 of 1
Author:  republica [ Thu Jan 13, 2011 1:55 pm ]
Post subject:  BreakVoid color
I noticed this error in the pDraw.class lines 3031-3033

Code:
   $BreakR      = isset($Format["BreakR"]) ? $Format["BreakR"] : 234;
   $BreakG      = isset($Format["BreakG"]) ? $Format["BreakG"] : 55;
   $BreakB      = isset($Format["BreakB"]) ? $Format["BreakB"] : 26;


For the following code (lines 3049-3052) to work (and use the serie color) they have to be set to NULL if they're not set in $Format:

Code:
   if ( $BreakR == NULL )
      $BreakSettings = array("R"=>$R,"G"=>$G,"B"=>$B,"Alpha"=>$Alpha,"Ticks"=>$VoidTicks,"Weight"=>$Weight);
   else
      $BreakSettings = array("R"=>$BreakR,"G"=>$BreakG,"B"=>$BreakB,"Alpha"=>$Alpha,"Ticks"=>$VoidTicks,"Weight"=>$Weight);
Author:  jean-damien [ Thu Jan 13, 2011 3:25 pm ]
Post subject:  Re: BreakVoid color
Hi,

This isn't exactly a bug as I wanted that break line was drawned in red by default but you're right, it is more logical to keep the serie color and allow the user to change it with a custom one manually.

I've modified the next sub release accordingly ;o)

Thank you!
JD.
Author:  republica [ Thu Jan 13, 2011 3:29 pm ]
Post subject:  Re: BreakVoid color
jean-damien wrote:
This isn't exactly a bug as I wanted that break line was drawned in red by default but you're right, it is more logical to keep the serie color and allow the user to change it with a custom one manually.


If the default color is supposed to be red then why have you written the following in the documentation;
Quote:
If you don‘t set a custom color, the serie color will be used.
Author:  jean-damien [ Thu Jan 13, 2011 5:18 pm ]
Post subject:  Re: BreakVoid color
Hopefully you've noticed it helping to maintain an up to date documentation ;o)
Author:  jean-damien [ Wed Jan 26, 2011 3:01 pm ]
Post subject:  Re: BreakVoid color
This has been fixed in the 2.1.0 that you can get from here : download.

Kind regards,
JD.
Page 1 of 1 All times are UTC
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
http://www.phpbb.com/